BIND 10 #117: NSEC3 RDATA needs more tests and has serious bugs

[BIND 10 Development]

#117: NSEC3 RDATA needs more tests and has serious bugs
-------------------------------------+-------------------------------------
                 Reporter:  jinmei   |                Owner:  jinmei
                     Type:  defect   |               Status:  reviewing
                 Priority:           |            Milestone:  A-Team-
  critical                           |  Sprint-20110223
                Component:           |           Resolution:
  DNSPacket API                      |            Sensitive:  0
                 Keywords:           |  Add Hours to Ticket:  0
Estimated Number of Hours:  0.0      |          Total Hours:  5.0
                Billable?:  0        |
                Internal?:  0        |
-------------------------------------+-------------------------------------
Changes (by vorner):

 * owner:  vorner => jinmei


Comment:

 I had little problems with compiling it (missing boost:: in front of
 lexical_cast) and there were some problems with make distcheck (the
 nsec_bitmap.* can't be nodist, that would mean they are not included in
 the distribution tarball). I fixed both of these, could you have a look if
 it is OK?

 With the code itself, it is OK. I have just two minor points:

 This is in the nsec_bitmap.cc:
 {{{
 for (int i = 0; i < total_len; i += len)
 }}}

 I do understand it and I like compressed code, but I noticed there's
 inclination to more wordy ways. As the len changes each iteration and the
 i moves by another 2 inside the body, use of for might be slightly
 misleading (it is usually used when the only one changing the i is the for
 cycle itself and with fixed length). While cycle might be more intuitive
 for that, but I personally don't mind this either.

 As you note the NSEC3 tests are the same as with NSEC at one place ‒ would
 it be possible to have them unified to have the code only once, let's say
 in some kind of template manner?

 Anyway, if you like this is the way you want it to be, the code is good
 enough to be merged.

-- 
Ticket URL: <http://bind10.isc.org/ticket/117#comment:15>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development