BIND 10 #346: A notify_out test fails without network connectivity

BIND 10 Development do-not-reply at isc.org
Thu Feb 17 15:15:33 UTC 2011


#346: A notify_out test fails without network connectivity
-------------------------------------+-------------------------------------
                 Reporter:  jinmei   |                Owner:  zzchen_pku
                     Type:  defect   |               Status:  reviewing
                 Priority:  minor    |            Milestone:  A-Team-
                Component:  xfrout   |  Sprint-20110223
                 Keywords:           |           Resolution:
Estimated Number of Hours:  0.25     |            Sensitive:  0
                Billable?:  1        |  Add Hours to Ticket:  0
                Internal?:  0        |          Total Hours:  0
-------------------------------------+-------------------------------------
Changes (by vorner):

 * owner:  vorner => zzchen_pku


Comment:

 Hello

 Most of the change is search and replace of the cn. to example.net., etc,
 which is OK.

 However, I find the mock socket class strange. The socket works like a
 pipe to itself ‒ whatever you send, you can then read from the same
 socket. I accept that it works currently, but if any other test wanted to
 use such mock socket, it could cause quite a surprise.

 May I suggest to change the mock class the recvfrom and sendto work on one
 of the sockets from socketpair and the other one is provided from some
 function to the testing end? (therefore, one would be the „local“ part of
 the socket for the application and the one that the test could request
 from it would be the fake „remote“ end). It would allow reading and the
 data that actually were sent to the socket as a bonus.

-- 
Ticket URL: <http://bind10.isc.org/ticket/346#comment:5>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list