BIND 10 #553: canceling wildcard match due to an empty non terminal

[BIND 10 Development]

#553: canceling wildcard match due to an empty non terminal
-------------------------------------+-------------------------------------
                 Reporter:  jinmei   |                Owner:  jinmei
                     Type:           |               Status:  reviewing
  enhancement                        |            Milestone:  A-Team-
                 Priority:  major    |  Sprint-20110223
                Component:  data     |           Resolution:
  source                             |            Sensitive:  0
                 Keywords:           |  Add Hours to Ticket:  0
Estimated Number of Hours:  5.0      |          Total Hours:  0
                Billable?:  1        |
                Internal?:  0        |
-------------------------------------+-------------------------------------

Comment (by jinmei):

 It basically looks okay.

 I have some minor editorial comments.
  - I've made trivial style fixes and pushed them directly.
  - s/trough/through/?
 {{{
                      * internal RBTree structure, which leaks out trough
 this
 }}}
  - should need a space between "expect" and "empty"
 {{{
 +                        "Wrong test, don't check for wild names if you
 expect"
 +                        "empty answer";
 }}}
  - maybe "multiple times" is more robust for future extensions than twice?
 {{{
 +    // Internal part of the cancelWildcard test that is run twice
 }}}
  - s/foo.example.org/foo.wild.example.org/? same for the next two
 SCOPED_TRACEs.
 {{{
 +        SCOPED_TRACE("Canceled under foo.example.org");
 }}}
  - s/foo.example.org/foo.wild.example.org/?
 {{{
 + * *.wild.example.org and bar.foo.example.org, then we know
 foo.example.org
 }}}
  - s/undef/under/?
 {{{
 +    // Try putting another one undef foo.wild....
 }}}

 As for changelog, I'd propose a higher level entry as I noted in #551.
 Something like:

 {{{
   170.? [func]          feng, jerry, jinmei, vorner
         b10-auth, src/lib/datasrc: in memory data source now works as a
         complete data source for authoritative DNS servers and b10-auth
         uses it.  It still misses major features, however, including
         DNSSEC support and zone transfer.
 }}}

-- 
Ticket URL: <http://bind10.isc.org/ticket/553#comment:9>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development