BIND 10 #253: xfrout should use the case-sensitive compress mode.
BIND 10 Development
do-not-reply at isc.org
Sat Feb 19 02:18:27 UTC 2011
#253: xfrout should use the case-sensitive compress mode.
-------------------------------------+-------------------------------------
Reporter: jinmei | Owner: vorner
Type: defect | Status: reviewing
Priority: minor | Milestone: A-Team-
Component: xfrout | Sprint-20110223
Keywords: | Resolution:
Estimated Number of Hours: 0.0 | Sensitive: 0
Billable?: 0 | Add Hours to Ticket:
Internal?: 0 | Total Hours:
-------------------------------------+-------------------------------------
Changes (by zzchen_pku):
* owner: zzchen_pku => vorner
Comment:
Replying to [comment:7 vorner]:
> - messagerenderer_python.cc:
> {{{
> // TODO: set/get compressmode
> }}}
> Can this be removed?
> - MessageRenderer_setCompressMode:
> {{{
> PyErr_SetString(PyExc_TypeError,
> "Message mode must be Message.PARSE or Message.RENDER")
> }}}
> The error message looks wrong (it might be a copy-paste from
somewhere).
> - The test_messagerenderer_set_compress_mode tries to set to case
sensitive mode. It would be helpful to test setting it back to case
insensitive as well.
Well,good catch,updated.
> - Is it possible to test if the _send_message actually sends correct
data, eg correctly compressed?
I don't intend to do it, because the underlying library unittest can
ensure the correctness, it's may be a duplicate in some sense. Is that
okay?
--
Ticket URL: <http://bind10.isc.org/ticket/253#comment:8>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list