BIND 10 #253: xfrout should use the case-sensitive compress mode.
BIND 10 Development
do-not-reply at isc.org
Mon Feb 21 08:47:00 UTC 2011
#253: xfrout should use the case-sensitive compress mode.
-------------------------------------+-------------------------------------
Reporter: jinmei | Owner: vorner
Type: defect | Status: reviewing
Priority: minor | Milestone: A-Team-
Component: xfrout | Sprint-20110223
Keywords: | Resolution:
Estimated Number of Hours: 0.0 | Sensitive: 0
Billable?: 0 | Add Hours to Ticket:
Internal?: 0 | Total Hours:
-------------------------------------+-------------------------------------
Changes (by zzchen_pku):
* owner: zzchen_pku => vorner
Comment:
Replying to [comment:9 vorner]:
> {{{
> render.set_compress_mode(MessageRenderer.CASE_SENSITIVE)
> }}}
>
> There's no test to check if it is there. If someone refactored the code
and forgot to set the compress mode to case sensitive, we wouldn't know it
at all. In that sense the code isn't tested. I don't say it must be tested
by reading the wire data, but at last some kind of test to check it was
set correctly should be there.
Got it, thanks for your clarification.
I have updated the unittest, please check.
--
Ticket URL: <https://bind10.isc.org/ticket/253#comment:10>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list