BIND 10 #602: provide dummy locks instead of those in boost/thread
BIND 10 Development
do-not-reply at isc.org
Wed Feb 23 23:04:55 UTC 2011
#602: provide dummy locks instead of those in boost/thread
-------------------------------------+-------------------------------------
Reporter: jelte | Owner: UnAssigned
Type: defect | Status: reviewing
Priority: major | Milestone: R-Team-
Component: | Sprint-20110308
Unclassified | Resolution:
Keywords: | Sensitive: 0
Estimated Number of Hours: 0.0 | Add Hours to Ticket: 0
Billable?: 1 | Total Hours: 0
Internal?: 0 |
-------------------------------------+-------------------------------------
Comment (by jinmei):
As discussed on jabber, I gave a quick review to the initial two parts
that can be retrieved by "git diff 14a5132^ 57b77aa".
A few small points:
- there are redundant spaces in blank lines/after EOL. I suggest you
check them by colored 'git diff' and remove them before merge.
- what's the purpose of this C-style cast?
{{{
+ sharable_lock(T mtype) { (void) mtype; }
}}}
(There are some more). If the purpose is to deceive the compiler
about an 'unused parameter', you can simply omit the parameter:
{{{
+ sharable_lock(T) {}
}}}
In any case we should avoid using C=style cast.
- semicolon is not necessary here:
{{{
+ void lock() {};
+ void unlock() {};
}}}
(there are other similar cases)
- why do we need <map>?
{{{
+#include <map>
}}}
My suggestion is to quickly fix these minor points (or even defer
these to a later cleanup) and defer the rest to an official R-team
sprint task.
--
Ticket URL: <http://bind10.isc.org/ticket/602#comment:3>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list