BIND 10 #613: Address CppCheck issues

[BIND 10 Development]

#613: Address CppCheck issues
-------------------------------------+-------------------------------------
                 Reporter:  stephen  |                Owner:  jinmei
                     Type:  defect   |               Status:  accepted
                 Priority:  major    |            Milestone:  A-Team-
                Component:           |  Sprint-20110309
  Unclassified                       |           Resolution:
                 Keywords:           |            Sensitive:  0
Estimated Number of Hours:  0.0      |  Add Hours to Ticket:  0
                Billable?:  1        |          Total Hours:  0
                Internal?:  0        |
-------------------------------------+-------------------------------------

Comment (by jinmei):

 Branch trac613 is ready for review.

 I've installed cppcheck 1.47 on my laptop, run it, and fixed most of
 the trivial issues.  I've also added a rule 'cppcheck' to the top
 Makefile.am with a suppression file, which contains a list of (semi)
 false positives.  On this branch 'make cppcheck' should succeed without
 any complaints and exit with a code of 0.

 I found cppcheck installed on bind10.isc.org was old and it produced
 a lot more complaints than 1.47.  Some are actually real bugs (e.g. it
 correctly detects the bug described in #460).  I don't know why 1.47
 doesn't complain about them; maybe newer versions tries to err on the
 side of fewer false positives.

 Anyway, my suggestion is
  - get this branch reviewed and merged
  - run it on some of buildbot boxes regularly.  if it stopped we should
    consider it a showstopper (just like any other build/test failure)

 As noted above, it doesn't work well with the currently installed version
 of cppcheck on bind10.isc.org.  I've built 1.47 under
 ~jinmei/src/cppcheck-1.47.  We can either (copy and) use it or if
 possible upgrade the installed version.

 This is the proposed changelog entry:
 {{{
   179.  [func]          jinmei
         Support cppcheck for static code check on C++ code.  If cppcheck
         is available, 'make cppcheck' on the top source directory will run
         the checker and should cleanly complete with an exit code of 0.
         Note: the suppression list isn't included in the final
         distributions.  It should be created by hand or retrieved from
         the git repository.
         (Trac #613, git TBD)
 }}}

-- 
Ticket URL: <http://bind10.isc.org/ticket/613#comment:3>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development