BIND 10 #388: There's no way to close UDPServer and TCPServer.
BIND 10 Development
do-not-reply at isc.org
Fri Feb 25 08:33:26 UTC 2011
#388: There's no way to close UDPServer and TCPServer.
-------------------------------------+-------------------------------------
Reporter: vorner | Owner: hanfeng
Type: defect | Status: reviewing
Priority: major | Milestone: A-Team-
Component: | Sprint-20110309
Unclassified | Resolution:
Keywords: | Sensitive: 0
Estimated Number of Hours: 0.0 | Add Hours to Ticket: 0
Billable?: 1 | Total Hours: 0
Internal?: 0 |
-------------------------------------+-------------------------------------
Comment (by hanfeng):
Replying to [comment:8 vorner]:
> Yes, but the main purpose here is to return the portnumber to the OS.
For return the port resource, we closed the socket.
> Anyway, is there a chance that such packet would miss it's finalization,
therefore leaking some resources? I didn't investigate it, but that would
be bad, if it could happen.
All the resources is wrapped in shared_ptr, so it unlikely will cause
resource leak
> While the stop() method is tested implicitly as part of clearServers(),
I believe we should have an explicit test for it. I noticed there's no
testing framework around the servers now, so it would be quite a lot of
work I guess (to write whole tests for TCPServer and UDPServer). And it
would be nice to have this fixed ASAP. So, unless you have an idea how to
do it easily, would you, please, merge this (if you agree with how I
enabled the tests) and create an A-backlog ticket for the tests?
Thanks. I have merged the code and create new ticket for dns server
testing.
--
Ticket URL: <http://bind10.isc.org/ticket/388#comment:9>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list