BIND 10 #419: Parallel xfrout session should be allowed

BIND 10 Development do-not-reply at isc.org
Fri Feb 25 18:19:51 UTC 2011


#419: Parallel xfrout session should be allowed
-------------------------------------+-------------------------------------
                 Reporter:           |                Owner:  zzchen_pku
  zhanglikun                         |               Status:  reviewing
                     Type:  defect   |            Milestone:  A-Team-
                 Priority:  major    |  Sprint-20110309
                Component:  xfrout   |           Resolution:
                 Keywords:           |            Sensitive:  0
Estimated Number of Hours:  0.0      |  Add Hours to Ticket:  0
                Billable?:  1        |          Total Hours:  0
                Internal?:  0        |
-------------------------------------+-------------------------------------
Changes (by vorner):

 * owner:  vorner => zzchen_pku


Comment:

 I would say it is almost ready. But I found one problem:

 {{{
  else:
          -                self._handle_request_noblock()
          +                # Create a new thread to handle requests for
 each auth
          +
 threading.Thread(target=self.handle_request).start()
 }}}

 The mixin class is in isc.util, which means it should be independent on
 what uses it. But it talks about auth in the comment (it probably
 shouldn't) and introduces threads to all applications that use it. I think
 that is not really OK. Would it be possible to call the
 _handle_request_nonblock() as before and in the case of the xfrout it
 would start the thread like this? Simply wrap it?

 Anyway, this way has another problem. The mixin test sometimes refuses to
 terminate. I guess it is related to the thread that is started but never
 stops (and it is not a daemon thread, therefore the python waits for it to
 terminate).

 Would you have a look at that as well, please?

 Thank you

-- 
Ticket URL: <https://bind10.isc.org/ticket/419#comment:13>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list