BIND 10 #458: Additional MX processing

[BIND 10 Development]

#458: Additional MX processing
-------------------------------+--------------------------------------------
      Reporter:  vorner        |        Owner:  vorner   
          Type:  task          |       Status:  reviewing
      Priority:  major         |    Milestone:           
     Component:  Unclassified  |   Resolution:           
      Keywords:                |    Sensitive:  0        
Estimatedhours:  0.0           |        Hours:  0        
      Billable:  1             |   Totalhours:  0        
      Internal:  0             |  
-------------------------------+--------------------------------------------
Changes (by jinmei):

  * owner:  jinmei => vorner


Comment:

 Replying to [comment:8 vorner]:
 > The comments should be addressed now. I use the code from #453, which
 simplifies it a little.
 >
 > The test is fixed and the one with alias added.
 >
 > Is it OK now?
 >
 It basically looks okay with a few minor points:
  - redundant parenthesis: ((name == Name("cnamemailer.example.com")))
  - integer vs boolean conversion: (options & FIND_GLUE_OK).  if we follow
 BIND 9 guideline it would have to be "(options & FIND_GLUE_OK) != 0"
  - we may want to use a prefix version of ++: additional_count++;
  - in the following case EXPECT_EQ would be a bit better:
 {{{
 +    EXPECT_TRUE(response.beginSection(Message::SECTION_ADDITIONAL) ==
 +        response.endSection(Message::SECTION_ADDITIONAL));
 }}}

-- 
Ticket URL: <http://bind10.isc.org/ticket/458#comment:9>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development