BIND 10 #473: ModuleCCSession only validates config data, not commands

[BIND 10 Development]

#473: ModuleCCSession only validates config data, not commands
-------------------------------------+-------------------------------------
                 Reporter:  jelte    |                Owner:  jinmei
                     Type:           |               Status:  reviewing
  enhancement                        |            Milestone:
                 Priority:  major    |           Resolution:
                Component:           |            Sensitive:  0
  configuration                      |  Add Hours to Ticket:  0
                 Keywords:           |          Total Hours:  0
Estimated Number of Hours:  2.0      |
                Billable?:  1        |
                Internal?:  0        |
-------------------------------------+-------------------------------------

Comment (by jinmei):

 Replying to [comment:5 jelte]:
 > proposed changelog:
 >
 > [bug] Jelte
 >       Command arguments were not validated internally against their
 >       specifications. This change fixes that.
 >
 I think we should clarify it's only for the C++ version.  Also don't
 forget the trac # and git commit ID.

 I also made some suggested (mostly) style changes in the branch.  Please
 check them.

 > >   - I hate to see a magic number:-)  What is this "3"? (in that sense
 > >     I don't like the hardcoded "1" below this line, either)
 >
 > Any value that is not zero :)
 > (yes we should formalize this and make a list of errors that can occur
 > in internal messages that expect responses, but i think that is more
 > general than just this and deserves its own ticket)
 >
 Fair enough.

 > > '''ccsession.h'''
 > >  - (not directly related to this change) I think the description could
 > >    be more detailed.  for example, an example would be useful.  I'd
 > >    also to know which exceptions can be thrown, if any (and there are
 > >    some, actually).
 >
 > You mean for the entire class? I'll do that separately then (so we can
 > progress this ticket).
 >
 Sorry, it was ambiguous.  I meant parseCommand() (improving overall
 document is always good, of course, but it's a never ending improvement,
 and certainly not a topic of a particular code fix).  An example would
 still be nice, but I'd leave the decision to you.

 The branch is basically okay to merge (if my suggested changes are okay).

-- 
Ticket URL: <https://bind10.isc.org/ticket/473#comment:6>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development