BIND 10 #427: bindctl/cfgmgr losing previous configurations

[BIND 10 Development]

#427: bindctl/cfgmgr losing previous configurations
-------------------------------------+-------------------------------------
                 Reporter:  jreed    |                Owner:  jelte
                     Type:  defect   |               Status:  reviewing
                 Priority:  major    |            Milestone:  R-Team-
                Component:           |  Sprint-20110125
  configuration                      |           Resolution:
                 Keywords:           |            Sensitive:  0
Estimated Number of Hours:  2.0      |  Add Hours to Ticket:  0
                Billable?:  1        |          Total Hours:  0
                Internal?:  0        |
-------------------------------------+-------------------------------------
Changes (by stephen):

 * owner:  stephen => jelte


Comment:

 Reviewed the code changes, they seem OK.

 I built the origin/trac427 branch from scratch and the changes fix the
 problem stated.  However, issuing the command "Boss shutdown" from bindctl
 causes an exception:
 {{{
 Exception happened during processing of request from ('127.0.0.1', 39045)
 Traceback (most recent call last):
   File "/usr/lib/python3.1/socketserver.py", line 558, in
 process_request_thread
     self.finish_request(request, client_address)
   File "/usr/lib/python3.1/socketserver.py", line 320, in finish_request
     self.RequestHandlerClass(request, client_address, self)
   File "/usr/lib/python3.1/socketserver.py", line 614, in __init__
     self.handle()
   File "/usr/lib/python3.1/http/server.py", line 352, in handle
     self.handle_one_request()
   File "/usr/lib/python3.1/http/server.py", line 346, in
 handle_one_request
     method()
   File "/home/stephen/bind10-dist/libexec/bind10-devel/b10-cmdctl", line
 140, in do_POST
     rcode, reply = self._handle_post_request()
   File "/home/stephen/bind10-dist/libexec/bind10-devel/b10-cmdctl", line
 205, in _handle_post_request
     rcode, reply = self.server.send_command_to_module(mod, cmd, param)
   File "/home/stephen/bind10-dist/libexec/bind10-devel/b10-cmdctl", line
 549, in send_command_to_module
     return self.cmdctl.send_command_with_check(module_name, command_name,
 params)
   File "/home/stephen/bind10-dist/libexec/bind10-devel/b10-cmdctl", line
 382, in send_command_with_check
     if not spec_obj.validate_command(command_name, params, errors):
   File "/home/stephen/bind10-dist/lib/python3.1/site-
 packages/isc/config/module_spec.py", line 116, in validate_command
     return _validate_spec_list(cmd['command_args'], True, cmd_params,
 errors)
   File "/home/stephen/bind10-dist/lib/python3.1/site-
 packages/isc/config/module_spec.py", line 342, in _validate_spec_list
     for item_name in data:
 TypeError: 'NoneType' object is not iterable
 }}}
 It is not clear whether the problem is related to this change.  For this
 reason, I suggest that the changes be merged (as they fix the problem with
 losing settings) and the merged code be tested for this problem.  If it is
 still present, open a new ticket for it.

-- 
Ticket URL: <http://bind10.isc.org/ticket/427#comment:7>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development