BIND 10 #513: b10-auth hangs in submitting statistics

[BIND 10 Development]

#513: b10-auth hangs in submitting statistics
-------------------------------------+-------------------------------------
                 Reporter:  jinmei   |                Owner:  jinmei
                     Type:  defect   |               Status:  reviewing
                 Priority:           |            Milestone:  A-Team-
  critical                           |  Sprint-20110126
                Component:           |           Resolution:
  b10-auth                           |            Sensitive:  0
                 Keywords:           |  Add Hours to Ticket:  0
Estimated Number of Hours:  0.0      |          Total Hours:  0
                Billable?:  1        |
                Internal?:  0        |
-------------------------------------+-------------------------------------
Changes (by y-aharen):

 * owner:  y-aharen => jinmei


Comment:

 I've completed my review.

 - src/bin/auth/auth_srv.cc:

 {{{
 109     /// Interval timer for periodic submission of statistics counters.
 110     /// When NULL, the submission is disabled.
 111     IntervalTimer statistics_timer_;
 }}}
 !IntervalTimer can't be NULL, it's not a pointer. I think the comment on
 line 110 can be deleted because the way to disable timer is described in
 the other place.


 - I think the interval value passed through cmdctl should be checked that
 is not negative (i.e. not < 0). In the current implementation, we can set
 Auth/statistics-interval to -1. It causes infinite invoking of call back
 function. The parameter check can be done in
 StatisticsIntervalConfig::build(). If the value is negative, it should
 throw !AuthConfigError or treat as 0 to disable timer. The choice of
 solution is up to you.

-- 
Ticket URL: <http://bind10.isc.org/ticket/513#comment:8>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development