BIND 10 #527: refactoring auth/query_unittests

[BIND 10 Development]

#527: refactoring auth/query_unittests
-------------------------------------+-------------------------------------
                 Reporter:  jinmei   |                Owner:  jinmei
                     Type:  task     |               Status:  new
                 Priority:  major    |            Milestone:  A-Team-
                Component:           |  Sprint-20110126
  b10-auth                           |           Resolution:
                 Keywords:           |            Sensitive:  0
Estimated Number of Hours:  2.0      |  Add Hours to Ticket:  0
                Billable?:  1        |          Total Hours:  0
                Internal?:  0        |
-------------------------------------+-------------------------------------

Comment (by jinmei):

 The branch trac527 is ready for review.

 It (mainly) contains two sets of changes:
  - changes to src/lib/testutils.  I've introduced a few new test utility
    functions, created a separate .h and .cc files for it, and moved
    the existing headerCheck() function to the new files (because it
    seems to be the more appropriate place).  The added functions are
    based on similar tests for sqlite3_unittest, but were more generalized
    and complete (eventually we want to merge these, but that would be a
    separate task).  This is an independent change and can be separately
    reviewed if the entire diff is too big.
  - changes to auth/tests/query_unittest.cc.  This is the main subject
    of this ticket.  The refactoring is quite substantial, so it's
    probably easier to simply compare the old and new tests to check
    if these essentially test the same things (rather than taking a diff).
    I added some comments about how the new mock zone works.  The new
    code shouldn't change the point of the tests (although the new ones
    actually do more detailed tests using the new tesutils) with one
    exception: MXAlias was different from what was actually intended,
    so I updated the test scenario.  See the log for commit
    cd2d518fbcb19a0119553f71593b7a9d908b90c3.

-- 
Ticket URL: <http://bind10.isc.org/ticket/527#comment:1>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development