BIND 10 #487: Handle query response from authoritative server

[BIND 10 Development]

#487: Handle query response from authoritative server
-------------------------------------+-------------------------------------
                 Reporter:  shane    |                Owner:  stephen
                     Type:           |               Status:  reviewing
  enhancement                        |            Milestone:  R-Team-
                 Priority:  major    |  Sprint-20110125
                Component:           |           Resolution:
  resolver                           |            Sensitive:  0
                 Keywords:           |  Add Hours to Ticket:  0
Estimated Number of Hours:  3.0      |          Total Hours:  0
                Billable?:  1        |
                Internal?:  0        |
-------------------------------------+-------------------------------------
Changes (by jelte):

 * owner:  jelte => stephen


Comment:

 Looks good, only a few minor comments;

 response_classifier.cc:234 according to the coding style guidelines (in
 this case the one from bind9) the ternary operator for a return value is a
 nono

 I am wondering if we should differentiate between a 'normal' ANSWER result
 and a CNAME-but-answer one (behaviour of the caller on both cases should
 be the same, but still)

 question.h contains a bit of garbage on line 191

 question_unittests: I know this isn't done in the existing tests here, but
 shouldn't we use EXPECT_EQ and EXPECT_NE instead of EXPECT_TRUE(a == b)
 etc?

-- 
Ticket URL: <http://bind10.isc.org/ticket/487#comment:4>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development