BIND 10 #517: Empty node processing in MemoryZone difficult Part
BIND 10 Development
do-not-reply at isc.org
Tue Jan 25 11:15:33 UTC 2011
#517: Empty node processing in MemoryZone difficult Part
-------------------------------------+-------------------------------------
Reporter: hanfeng | Owner: jinmei
Type: | Status: reviewing
enhancement | Milestone: A-Team-
Priority: major | Sprint-20110126
Component: data | Resolution:
source | Sensitive: 0
Keywords: | Add Hours to Ticket: 0
Estimated Number of Hours: 0.0 | Total Hours: 0
Billable?: 1 |
Internal?: 0 |
-------------------------------------+-------------------------------------
Comment (by hanfeng):
Replying to [comment:5 jinmei]:
> Most of the editorial changes are s/foo */foo*/, s/foo &/foo&/, etc.
> This seems to be quite common patches you submitted. If this convention
> is difficult for you to follow, I'd suggest you write a simple checker
Yes, I am used to write "foo *" instead of "foo*", I will pay more
attention. Thanks
> One non-editorial change is that for the RBTree class constructor.
> I changed needsReturnEmptyNode_ to a const variable (so that we
> don't have to worry about the case where it's dynamically modified),
Although make a bool value const is a little uncommon, it's acceptable
for current implementation.
> Another observation. Some of the newly written documentation doesn't
seem
> to be sufficient. In general, we should provide for each method/class
More comment is added
--
Ticket URL: <http://bind10.isc.org/ticket/517#comment:6>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list