BIND 10 #445: Review Recursor cache design

[BIND 10 Development]

#445: Review Recursor cache design
-------------------------------------+-------------------------------------
                 Reporter:           |                Owner:  zhanglikun
  zhanglikun                         |               Status:  reviewing
                     Type:  task     |            Milestone:  R-Team-
                 Priority:  major    |  Sprint-20110208
                Component:           |           Resolution:
  resolver                           |            Sensitive:  0
                 Keywords:           |  Add Hours to Ticket:  0
Estimated Number of Hours:  5.0      |          Total Hours:  0
                Billable?:  1        |
                Internal?:  0        |
-------------------------------------+-------------------------------------
Changes (by smann):

 * owner:  smann => zhanglikun
 * status:  assigned => reviewing


Comment:

 I have made some changes directly to the design document, but they are
 just for clarification purposes (e.g., putting in a link to the
 requirements document).

 Here are my detailed comments:

 1. Don't use the word "should" in a design document. Instead use "will" or
 "is." Should means maybe and a design document describes how something
 works.

 2. In section "About RR Class", under "Others". Please clarify what you
 mean by "the supported class should be configurable." Do you mean the
 supported class list?

 3. In "Main Data Structures," you list functions/methods for both the
 resolver cache and message cache. Each of these functions need
 input/output descriptions. The one sentence description of each method is
 fine (but you need to provide the ones that are missing under "Message
 Cache")

 4. Same comments for "RRset Cache".

 5. You might consider putting the data object descriptions before the
 method descriptions. That way, when you describe the inputs and outputs,
 you can just reference the object name (already described).

 6. Under "Miscellaneous Consideration -> Update Operation": what will you
 use to determine whether an RRSet is more authoritative. What happens if
 that information isn't available?

 It looks like you were going to use links to separate pages for
 descriptions of various methods and data objects. That's ok, but right now
 most of them don't exist. If you aren't going to use separate pages, take
 the links out.

 Also, I think that the Resolver Cache Query Algorithm needs a diagram, but
 I do not think that is important right now, unless you have extra time :)

-- 
Ticket URL: <http://bind10.isc.org/ticket/445#comment:8>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development