BIND 10 #747: Conversion of server common library to use the new logging interface
BIND 10 Development
do-not-reply at isc.org
Mon Jul 4 09:35:03 UTC 2011
#747: Conversion of server common library to use the new logging interface
-------------------------------------+-------------------------------------
Reporter: | Owner: vorner
stephen | Status: reviewing
Type: | Milestone:
enhancement | Sprint-20110712
Priority: major | Resolution:
Component: | Sensitive: 0
Unclassified | Sub-Project: Core
Keywords: | Estimated Difficulty: 4.0
Defect Severity: N/A | Total Hours: 0
Feature Depending on Ticket: |
Add Hours to Ticket: 0 |
Internal?: 0 |
-------------------------------------+-------------------------------------
Changes (by stephen):
* owner: stephen => vorner
Comment:
> But, isn't it duplicate, if it just simply says it is a version of that?
Doesn't that say enough about what it returns? I know good documentation
is needed, but does it help to copy-paste it around?
It's really for the Doxygen output. I think that if the description is a
long one, referring to the description in another method is fine. But the
parameter and return code descriptions are usually one-liners, and if
anyone just needs a "quick reference", it is there. In this example, the
description:
{{{
Simply for convenience, so the .what() doesn't have to be typed.
}}}
could easily be replaced by something like:
{{{
\param e Exception from which the "what()" is extracted and inserted into
the message.
}}}
(or something like that.) However, I'll leave it up to you if you want to
change it - it's a simple method and I'm not dogmatic about it. (If you
decide to change it, I do not need to see the change.)
The rest fine, although I've corrected a typo and made some minor changes
to the phrasing of a couple of messages in server_common_messages.mes (the
changes have been pushed).
Please go ahead and merge.
--
Ticket URL: <http://bind10.isc.org/ticket/747#comment:10>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list