BIND 10 #1071: introduce "null" output for logs
BIND 10 Development
do-not-reply at isc.org
Mon Jul 4 14:39:57 UTC 2011
#1071: introduce "null" output for logs
-------------------------------------+-------------------------------------
Reporter: | Owner: stephen
jinmei | Status: reviewing
Type: task | Milestone:
Priority: major | Sprint-20110712
Component: | Resolution:
logging | Sensitive: 0
Keywords: | Sub-Project: DNS
Defect Severity: N/A | Estimated Difficulty: 0.0
Feature Depending on Ticket: | Total Hours: 0
Add Hours to Ticket: 0 |
Internal?: 0 |
-------------------------------------+-------------------------------------
Changes (by vorner):
* owner: vorner => stephen
Comment:
Hello
Replying to [comment:8 stephen]:
> > I don't know if I look correctly, but this seems to be more setting-up
of logging options through environment variables. There seems to be no
code regarding any null output. Do I look at a wrong branch or is it
related in some way I don't see?
> It adds B10_LOGGER_DESTINATION. Setting that to /dev/null will route
the output to the null device. I've added some text to
[wiki:LoggingCppApiDesign] to describe this and will post a message to
bind10-dev prior to committing #1024 to explain it.
Will it route them there by default or is it needed to specify manually?
Would that make sense to be default? I don't really mind it this way,
since I run distcheck from a script and putting it there isn't a problem
for me.
> > This doesn't seem to be completely true (the part about "as is", the
%1, etc are replaced): The rest of the line - from the first non-space
character to the last non-space character - is taken exactly as-is for the
text of the message.
> I've combined this paragraph and the succeeding one (that talks about
the replacement tokens); does this remove the ambiguity?
Well, I wasn't really worried about ambiguity, but about the sentence not
being true (I understand „as-is“ to be completely unmodified, but the
placeholders are modified). I tried to modify it a bit, is it OK for you
this way?
> > Also, this looks really strange. Why is the "1" there?
> > ./init_logger_test 1> $destfile
> For symmetry: the following test a few lines down routes output to
stderr (and so contains a "2>"). The "1>" is meant to emphasise the
difference.
I find it surprising this way. But it is correct, so I don't really mind,
it's just question if it is better to be symmetric or usual.
If you agree with my change of the text, it can probably be merged.
--
Ticket URL: <http://bind10.isc.org/ticket/1071#comment:9>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list