BIND 10 #981: The NOT ACL operator
BIND 10 Development
do-not-reply at isc.org
Tue Jul 5 10:32:22 UTC 2011
#981: The NOT ACL operator
-------------------------------------+-------------------------------------
Reporter: | Owner: vorner
vorner | Status: reviewing
Type: task | Milestone:
Priority: major | Sprint-20110712
Component: | Resolution:
Unclassified | Sensitive: 0
Keywords: | Sub-Project: DNS
Defect Severity: N/A | Estimated Difficulty: 2.0
Feature Depending on Ticket: ACL | Total Hours: 0
Add Hours to Ticket: 0 |
Internal?: 0 |
-------------------------------------+-------------------------------------
Changes (by stephen):
* owner: stephen => vorner
Comment:
Reviewed commit ea2a4f906dc3b5bae939a0348a5f82fa690bbec5. Just one
comment:
'''src/lib/acl/logic_check.h'''
It does occur to me that there is now an inconsistency in class names.
Logic operators include the operations AND, OR and NOT. Only AND and OR
(i.e. All and Any) are handled by the class !LogicOperator. NOT is
handled by the class !NotCheck. For consistency, !NotCheck should be
renamed !NotOperator (or !LogicOperator renamed to !LogicCheck).
(Ideally, !LogicOperator should also be renamed to indicate that it is
restricted to just AND and OR, but at the moment I can't think of a better
name.)
--
Ticket URL: <http://bind10.isc.org/ticket/981#comment:6>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list