BIND 10 #741: Conversion of cache library to use the new logging interface

BIND 10 Development do-not-reply at isc.org
Tue Jul 5 13:54:19 UTC 2011


#741: Conversion of cache library to use the new logging interface
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  vorner
  stephen                            |                Status:  reviewing
                       Type:         |             Milestone:
  enhancement                        |  Sprint-20110712
                   Priority:  major  |            Resolution:
                  Component:         |             Sensitive:  0
  resolver                           |           Sub-Project:  DNS
                   Keywords:         |  Estimated Difficulty:  5.0
            Defect Severity:  N/A    |           Total Hours:  0
Feature Depending on Ticket:         |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by jelte):

 * owner:  jelte => vorner


Comment:

 I made one commit, I removed the empty lines after the ID line in the .mes
 file (which is not present in any of the other message files), and i fixed
 one trivial typo.

 Just a couple of minor points:

 general:

 I suspect we might want to set the debuglevel values for these things a
 bit higher, but let's wait on the global debuglevel definition for that.


 cache_messages.mes:

 CACHE_MESSAGES_INIT

 In the other _INIT line the message reads 'X messages of class Y', which I
 think sounds better than the 'X Y messages' that is used here.

 CACHE_MESSAGES_UNCACHEABLE

 'This is for some reason described in RFC2308.'

 I suggest we specify a bit more here; e.g. something like 'cannot be
 cached, because there is no SOA record in the message. See RFC 2308
 section 5 for more information.'


 CACHE_RRSET_EXPIRED

 Description seems to miss something. Should it be 'the requested data was
 found in the RRset cache'?


 CACHE_RRSET_LOOKUP

 can (and should?) this message print the class too? Same for
 CACHE_RRSET_NOT_FOUND

-- 
Ticket URL: <http://bind10.isc.org/ticket/741#comment:7>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list