BIND 10 #1025: logging argument should be more carefully checked

[BIND 10 Development]

#1025: logging argument should be more carefully checked
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  UnAssigned
  jinmei                             |                Status:  reviewing
                       Type:         |             Milestone:
  defect                             |  Sprint-20110712
                   Priority:  major  |            Resolution:
                  Component:         |             Sensitive:  0
  Unclassified                       |           Sub-Project:  Core
                   Keywords:         |  Estimated Difficulty:  3.0
            Defect Severity:  N/A    |           Total Hours:  0
Feature Depending on Ticket:         |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by stephen):

 * owner:  stephen => UnAssigned
 * status:  assigned => reviewing


Comment:

 I've done a bit more thinking about this, and realised that a conversion
 to a string is highly unlikely to fail with a bad_lexical_cast error as
 virtually every data type can be represented as a string. (Conversion
 ''from'' strings is another matter.)  A failure when converting to a
 string is more likely to be due to a memory allocation failure or an
 object-specific exception raised in its operator<<() method, neither of
 which should be handled in the Formatter::arg() method.

 As bad_lexical_cast exception in these circumstances is therefore a
 potentially serious error, on reflection I think Jinmei is right and that
 converting the exception to a BIND 10 one is the best solution.

-- 
Ticket URL: <http://bind10.isc.org/ticket/1025#comment:7>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development