BIND 10 #712: wrong error message for xfrin if zone_name="."

[BIND 10 Development]

#712: wrong error message for xfrin if zone_name="."
-------------------------------------+-------------------------------------
                   Reporter:  jreed  |                 Owner:  jreed
                       Type:         |                Status:  assigned
  defect                             |             Milestone:
                   Priority:  minor  |  Sprint-20110712
                  Component:  xfrin  |            Resolution:
                   Keywords:         |             Sensitive:  0
            Defect Severity:  N/A    |           Sub-Project:  DNS
Feature Depending on Ticket:         |  Estimated Difficulty:  2.0
        Add Hours to Ticket:  0      |           Total Hours:  0
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by vorner):

 * owner:  vorner => jreed
 * status:  accepted => assigned


Comment:

 Hello

 While investigating this issue, I discovered this:

 {{{
 > Xfrin retransfer {"zone_name": "."}
 {
     "error": "bad zone class: \"zone_name\":\".\" (Unrecognized RR
 parameter string)"
 }
 > Xfrin retransfer "zone_name": "."
 {
     "error": "Master address not given or configured for
 \\\"zone_name\\\":\\032\\\".\\\"."
 }
 > Xfrin retransfer zone_name=.
 {
     "error": "Master address not given or configured for zone_name=."
 }
 > Xfrin retransfer zone_name .
 {
     "error": "bad zone class: . (Unrecognized RR parameter string)"
 }
 > Xfrin retransfer .
 "zone xfrin is started"
 }}}

 So, I have a guess: you typed zone_name="." master=127.0.0.1, which took
 zone_name="." as a whole as zone name and master=127.0.0.1 as the next
 positional parameter, the zone_class. In that sense, the error message
 from xfrin is correct, since it is clearly invalid class string.

 But I agree this the response is not really intuitive. So, what do we do
 about it? I see some options:
  * Make bindctl understand understand keyword arguments
  * Have the help (eg. when typing Xfrin retransfer without parameters)
 better
  * Have some heuristic to say that the arguments look like meaning
 something else (eg. they contain =)

 What do you propose?

-- 
Ticket URL: <http://bind10.isc.org/ticket/712#comment:5>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development