BIND 10 #1146: Stop hiding errors in XfrOut

[BIND 10 Development]

#1146: Stop hiding errors in XfrOut
-------------------------------+-----------------------------------------
            Reporter:  vorner  |                        Owner:
                Type:  defect  |                       Status:  new
            Priority:  minor   |                    Milestone:  New Tasks
           Component:  xfrout  |                     Keywords:
           Sensitive:  0       |              Defect Severity:  N/A
         Sub-Project:  DNS     |  Feature Depending on Ticket:
Estimated Difficulty:  0       |          Add Hours to Ticket:  0
         Total Hours:  0       |                    Internal?:  0
-------------------------------+-----------------------------------------
 There's this statement in the `xfrout.py.in` file:

 {{{#!python
 try:
     from libutil_io_python import *
     from pydnspp import *
 except ImportError as e:
     # C++ loadable module may not be installed; even so the xfrout process
     # must keep running, so we warn about it and move forward.
     log.error(XFROUT_IMPORT, str(e))
 }}}

 This makes sure the process is started even if the DNS library can not be
 loaded. In such case, the process will be useless, because it won't
 understand any requests and this exceptions only masks the real problem
 (the library is not properly installed or the installation is corrupt),
 pretending everything is OK and just not answering the queries.

 Besides having these bad properties, hiding errors in code kind of smells.

 As noted in the
 https://lists.isc.org/pipermail/bind10-dev/2011-July/002477.html email
 discussion, this is here because if there's a problem, the boss keeps
 restarting it, which is annoying. But I believe this is problem of Boss,
 not every program that has a fatal unrecoverable problem.

 So I suggest we remove this thing and make XfrOut crash if it can't
 perform its goal as every well behaved program.

-- 
Ticket URL: <http://bind10.isc.org/ticket/1146>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development