BIND 10 #983: Python wrappers for ACLs

BIND 10 Development do-not-reply at isc.org
Thu Jul 14 07:07:42 UTC 2011


#983: Python wrappers for ACLs
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  jinmei
  vorner                             |                Status:  reviewing
                       Type:  task   |             Milestone:
                   Priority:  major  |  Sprint-20110802
                  Component:         |            Resolution:
  Unclassified                       |             Sensitive:  0
                   Keywords:         |           Sub-Project:  DNS
            Defect Severity:  N/A    |  Estimated Difficulty:  5.0
Feature Depending on Ticket:  ACL    |           Total Hours:  0
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by vorner):

 * owner:  vorner => jinmei


Comment:

 Hello

 Replying to [comment:18 jinmei]:
 > So I revised the code further: First, isc.acl.__init__.py now
 > explicitly imports json (just to be explicit; as noted above, this is
 > actually a redundant operation in normal cases).  Second, I moved the
 > access code to json.dumps() from load() to the class initialization
 > function.  This way, we could defend us against some time of evil
 > behavior such as deleting sys.module['json'] after importing the dns
 > module.

 OK, this looks good.

 > > The documentation for the loader is taken from the C++ one and it
 speaks about loading the checks. There's no function and no binding for
 the checks currently, should that part be removed?
 >
 > It at least notes create/registration (if you mean it by 'loading the
 > checks') is not available in the python version:
 > {{{
 > To allow any kind of checks to exist in the application, creators are\n\
 > registered for the names of the checks (this feature is not yet\n\
 > available for the python API).\n\
 > }}}

 I was worried about this paragraph, which is not true about the python
 version:
 {{{
 The class can be used to load the checks only. This is supposed to be\n\
 used by compound checks to create the subexpressions.\n\
 }}}

 So either removing it or noting that this functionality is not wrapped yet
 could be helpful.

 But either way, I think this is small enough change, so it can be merged
 (with or without this change).

 Thank you

-- 
Ticket URL: <http://bind10.isc.org/ticket/983#comment:20>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list