BIND 10 #929: Add an interface into cfgmgr to get statistics list of each module

BIND 10 Development do-not-reply at isc.org
Thu Jul 14 09:56:36 UTC 2011


#929: Add an interface into cfgmgr to get statistics list of each module
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  naokikambe
  naokikambe                         |                Status:  reviewing
                       Type:         |             Milestone:
  enhancement                        |  Sprint-20110802
                   Priority:  major  |            Resolution:
                  Component:         |             Sensitive:  0
  configuration                      |           Sub-Project:  DNS
                   Keywords:         |  Estimated Difficulty:  15.0
            Defect Severity:  N/A    |           Total Hours:  0
Feature Depending on Ticket:         |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by jelte):

 * owner:  jelte => naokikambe


Comment:

 hey I noticed the commit log in the branch seems somewhat off, i see a lot
 of commits twice (with some commits from other branches in between). Can
 it be that you rebased a branch that was already pushed upstream or
 something? (if you are available somewhere in the near future perhaps we
 can talk about this on jabber, i think this may also be the case in the
 two other branches)

 In general, the code looks ok, tests are nice, and additions seem to work
 nicely with the existing code.

 One question; Won't we need a validateSpec (and getStatisticsSpec or
 something) in the c++ variant? (perhaps not, but in that case we might
 want to make a note of that somewhere)


 and just a trivial comment in module_spec.py:

 in validate_statistics():

 {{{if stat_spec != None:}}}

 this should work correctly (in general), but it is slightly better to use

 {{{if stat_spec is not None:}}}

-- 
Ticket URL: <http://bind10.isc.org/ticket/929#comment:7>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list