BIND 10 #1150: python test scripts generated by configure should be in _SCRIPTS

BIND 10 Development do-not-reply at isc.org
Fri Jul 15 21:28:55 UTC 2011


#1150: python test scripts generated by configure should be in _SCRIPTS
-------------------------------------+-------------------------------------
            Reporter:  jinmei        |                        Owner:  jreed
                Type:  enhancement   |                       Status:  new
            Priority:  major         |                    Milestone:  Next-
           Component:  build system  |  Sprint-Proposed
           Sensitive:  0             |                     Keywords:
         Sub-Project:  Core          |              Defect Severity:  N/A
Estimated Difficulty:  0             |  Feature Depending on Ticket:
         Total Hours:  0             |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
 In xfrout/tests, the test script is generated from .in at ./configure
 time, but the generated script is specified as EXTRA_DIST:

 {{{
 PYTESTS = xfrout_test.py
 EXTRA_DIST = $(PYTESTS)
 }}}
 (there's xfrout_test.py.in)

 This is not good in that
 - we include the auto generated file in the tar ball (not necessarily
   harmful, but it's redundant)
 - when we edit .py.in, we need to run the top level ./configure again
   in order to generate the corresponding .py

 Instead, we should do specify .py as noinst_SCRIPTS like this:
 {{{
 PYTESTS = xfrout_test.py
 noinst_SCRIPTS = $(PYTESTS)
 # no EXTRA_DIST
 }}}

 Then, gnu make can automatically regenerate .py (and only that .py)
 when we update .py.in.

 But that would cause a regression in tests for process.rename (in
 lib/python/isc/util).  So this task will include preventing the
 regression.

 Also, there may be other such test scripts.  They should be identified
 and fixed same way.

-- 
Ticket URL: <http://bind10.isc.org/ticket/1150>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list