BIND 10 #1155: Solaris x86 8.0 build fixes

[BIND 10 Development]

#1155: Solaris x86 8.0 build fixes
-------------------------------------+-------------------------------------
                   Reporter:  dvv    |                 Owner:  dvv
                       Type:         |                Status:  reviewing
  defect                             |             Milestone:
                   Priority:  major  |  Sprint-20110802
                  Component:         |            Resolution:
  Unclassified                       |             Sensitive:  0
                   Keywords:         |           Sub-Project:  DNS
            Defect Severity:  N/A    |  Estimated Difficulty:  0
Feature Depending on Ticket:         |           Total Hours:  0
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by stephen):

 * owner:  stephen => dvv


Comment:

 OK, but a couple of points:

 As {{{-Wno-missing-braces}}} is only needed on Solaris, I think we should
 try to leave it in for other operating systems as it provides an
 additional check on our code. Rather than add it unconditionally to the
 definition of B10_CXXFLAGS, it could be appended to it in the "case"
 statement that follows the definition (which already contains a branch for
 Solaris) i.e. {{{B10_CXXFLAGS="$B10_CXXFLAGS -Wno-missing-braces"}}}. (A
 comment should be added as to what problem caused the need for the
 exemption - presumably a Solaris header generates an error?)

 Suggest adding a comment to rrtype-placeholder.h noting that Solaris
 defines the macro DS which interferes with the definition of the DS
 record.

-- 
Ticket URL: <https://bind10.isc.org/ticket/1155#comment:4>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development