BIND 10 #1128: RR type implementation: SRV

[BIND 10 Development]

#1128: RR type implementation: SRV
-------------------------------------+-------------------------------------
                   Reporter:  shane  |                 Owner:  zzchen_pku
                       Type:         |                Status:  reviewing
  enhancement                        |             Milestone:
                   Priority:  major  |  Sprint-20110802
                  Component:         |            Resolution:
  DNSPacket API                      |             Sensitive:  0
                   Keywords:         |           Sub-Project:  DNS
            Defect Severity:  N/A    |  Estimated Difficulty:  0.0
Feature Depending on Ticket:         |           Total Hours:  0
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------

Comment (by zzchen_pku):

 Replying to [comment:6 jinmei]:
 > Not intending to steal the review process, but as I happen to notice a
 > couple of things...
 >
 > - The "from string" constructor incorrectly accepts this:
 > {{{
 >     generic::SRV("1 5 1a.example.com.");
 > }}}
 Fixed.
 I reused getToken() and tokenToNum() from TSIG, and I think the two
 methods can be put into utils, how do you think about it?
 > - Documentation is missing overall. (Don't follow the bad existing
 >   practice:-).  See, e.g., the tsig_250 implementation for what's
 expected.
 Done.

-- 
Ticket URL: <http://bind10.isc.org/ticket/1128#comment:8>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development