BIND 10 #955: xfrin should check TSIG before other part of incoming message

[BIND 10 Development]

#955: xfrin should check TSIG before other part of incoming message
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  zzchen_pku
  jinmei                             |                Status:  reviewing
                       Type:         |             Milestone:
  defect                             |  Sprint-20110614
                   Priority:  major  |            Resolution:
                  Component:  xfrin  |             Sensitive:  0
                   Keywords:         |           Sub-Project:  DNS
            Defect Severity:  N/A    |  Estimated Difficulty:  0.0
Feature Depending on Ticket:         |           Total Hours:  0
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------

Comment (by zzchen_pku):

 Replying to [comment:6 jinmei]:
 > Replying to [comment:5 zzchen_pku]:
 > > Ready for review, let xfrin check tsig status first.
 >
 > Unless I miss something, there's no test for this.
 Because I just reversed the checking order, both of the checking will
 raise XfrinException and discard bogus responses, so the function of the
 interface has not been changed, the original test should be enough to
 handle it.
 > Also, before picking up a new development task (after finishing one),
 > could you first consider purging open review requests?  If everyone
 > only takes on new development tasks and keeps asking for review, the
 > size of the review queue will be monotonically increased and will
 > never be empty.
 oh, currently, almost all review tickets have been assigned to somebody,
 except #767 and #755.
 (#767 require discussion  and #755 was done after I picked this task.)

-- 
Ticket URL: <http://bind10.isc.org/ticket/955#comment:8>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development