BIND 10 #976: Add syslog appender to logging code
BIND 10 Development
do-not-reply at isc.org
Tue Jun 7 12:43:29 UTC 2011
#976: Add syslog appender to logging code
-------------------------------------+-------------------------------------
Reporter: | Owner: stephen
stephen | Status: reviewing
Type: task | Milestone:
Priority: major | Sprint-20110614
Component: | Resolution:
logging | Sensitive: 0
Keywords: | Sub-Project: DNS
Defect Severity: N/A | Estimated Difficulty: 0.0
Feature Depending on Ticket: | Total Hours: 0
Add Hours to Ticket: 0 |
Internal?: 0 |
-------------------------------------+-------------------------------------
Changes (by jelte):
* owner: jelte => stephen
Comment:
I've updated one trivial typo in src/lib/log/logger.h's doxygen, and I saw
two more but did not know exactly what to make of it; 'disction' on line
70 (i assume it is supposed to say dictionary, but i'm not sure), and the
sentence on line 82 does not seem to have been finished (... using.)
Code itself looks good. I do have one bikesheddy comment, and that may be
personal preference; I tend to view 'syslog' as one name of a system for
logging. As such, my CamelCasing would be Syslog, not SysLog.
And finally, a question; do we think we can make our test shellscripts not
print the actual log messages themselves? (i've been meaning to make the
rest of the tests 'disable' logs completely, I really don't want to see
ERROR and WARN etc unless there is something wrong. Of course we need to
trigger that said messages are logged, but if possible, I'd like to not
show them).
--
Ticket URL: <http://bind10.isc.org/ticket/976#comment:7>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list