BIND 10 #955: xfrin should check TSIG before other part of incoming message

[BIND 10 Development]

#955: xfrin should check TSIG before other part of incoming message
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  jinmei
  jinmei                             |                Status:  reviewing
                       Type:         |             Milestone:
  defect                             |  Sprint-20110614
                   Priority:  major  |            Resolution:
                  Component:  xfrin  |             Sensitive:  0
                   Keywords:         |           Sub-Project:  DNS
            Defect Severity:  N/A    |  Estimated Difficulty:  2.0
Feature Depending on Ticket:         |           Total Hours:  0
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by zzchen_pku):

 * owner:  zzchen_pku => jinmei


Comment:

 Replying to [comment:14 jinmei]:
 > Your solution is impressive:-) but I have a concern.  With this approach
 > the original stdout is closed after a test, which may cause unexpectedly
 > bad side effect (even if not, it's generally not good to leave a global
 > side effect after a test case).  I'd suggest catching and examining
 > the exception and the error message explicitly.  See the attached
 > sample diff.
 >
 > We may want to generalize it and move it somewhere else so that other
 > tests can use it; or this may just have to be a short term workaround
 > until we solve the other generic issue (below).  In any case that will
 > be beyond the scope of this ticket, so I'm okay with having it within
 > xfrin for now.
 >
 > Note also that with this approach you won't need to tweak the body of
 > xfrin as you did in the previous commit.
 Good suggestion, applied:-)
 > > Agree, can you create ticket for it?
 >
 > Yes, please.
 #1007 has been created for it.

-- 
Ticket URL: <http://kojiki.server.ne.jp/ticket/955#comment:16>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development