BIND 10 #997: Create the ACL class
BIND 10 Development
do-not-reply at isc.org
Tue Jun 14 18:33:23 UTC 2011
#997: Create the ACL class
-------------------------------------+-------------------------------------
Reporter: | Owner: jinmei
vorner | Status: reviewing
Type: task | Milestone:
Priority: major | Sprint-20110628
Component: | Resolution:
Unclassified | Sensitive: 0
Keywords: | Sub-Project: Core
Defect Severity: N/A | Estimated Difficulty: 0.0
Feature Depending on Ticket: | Total Hours: 0
Add Hours to Ticket: 0 |
Internal?: 0 |
-------------------------------------+-------------------------------------
Changes (by vorner):
* owner: vorner => jinmei
Comment:
Replying to [comment:7 jinmei]:
> There are several ways to avoid the "obvious waste", and one
> straightforward way is to define the end iterator explicitly, outside
> the scope of the loop
Hmm, why I didn't think of this? Maybe it was so simple I missed it O:-).
Actually, this can help even if theoretically completely smart compiler,
as there's no guarantee the end() pointer couldn't be changed from inside
a call to some check. Thanks for the suggestion.
> One other minor point(s): if we change "policy" to "default action" in
> acl.h, it would be better to make it consistent in acl_test.c. For
Lack of concentration on my side I guess. There should be no more policies
in the code now.
Is it better?
--
Ticket URL: <http://bind10.isc.org/ticket/997#comment:10>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list