BIND 10 #997: Create the ACL class
BIND 10 Development
do-not-reply at isc.org
Tue Jun 14 18:44:09 UTC 2011
#997: Create the ACL class
-------------------------------------+-------------------------------------
Reporter: | Owner: jinmei
vorner | Status: reviewing
Type: task | Milestone:
Priority: major | Sprint-20110628
Component: | Resolution:
Unclassified | Sensitive: 0
Keywords: | Sub-Project: Core
Defect Severity: N/A | Estimated Difficulty: 0.0
Feature Depending on Ticket: | Total Hours: 0
Add Hours to Ticket: 0 |
Internal?: 0 |
-------------------------------------+-------------------------------------
Comment (by jinmei):
Replying to [comment:10 vorner]:
> > One other minor point(s): if we change "policy" to "default action" in
> > acl.h, it would be better to make it consistent in acl_test.c. For
>
> Lack of concentration on my side I guess. There should be no more
policies in the code now.
>
> Is it better?
Yes.
And I made a few more editorial cleanups. They include the change
from underscore to camel for a *method*.
One final thing is that I'd constify the end iterator:
{{{
typename Entries::const_iterator const end(entries_.end());
}}}
but in this case the entire amount of code is very small, so it's
mostly a matter of taste. I'd leave it to you.
Please merge with or without it.
--
Ticket URL: <http://bind10.isc.org/ticket/997#comment:12>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list