BIND 10 #1010: Configuration of the Python logging API

[BIND 10 Development]

#1010: Configuration of the Python logging API
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  jelte
  stephen                            |                Status:  reviewing
                       Type:  task   |             Milestone:
                   Priority:  major  |  Sprint-20110628
                  Component:         |            Resolution:
  logging                            |             Sensitive:  0
                   Keywords:         |           Sub-Project:  DNS
            Defect Severity:  N/A    |  Estimated Difficulty:  0.0
Feature Depending on Ticket:         |           Total Hours:  0
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by vorner):

 * owner:  vorner => jelte


Comment:

 Hello

 I noticed few things:
  * The distcheck fails for me, it can't find the module. For some reason
 it didn't fail before. Does it run for you?
  * With the `default_logconfig_handler`, the `n` parameter doesn't seem
 too descriptive. Wouldn't there be a better name?
  * The `InternalError` was kind of expected to only propagate up trough
 the stack when there already is a python exception registered. The way you
 first throw `InternalError` and after catching it, you make it
 inconsistent. Could it possibly be reversed?
  * Wouldn't the whole conversion be easier like converting to JSON string
 and passing the string to Element::fromJSON? I think the code would be
 shorter with better code reuse. But it might look less elegant on the
 other hand, so I'm not sure which one is better.

 Thanks

-- 
Ticket URL: <http://bind10.isc.org/ticket/1010#comment:5>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development