BIND 10 #1008: missing initLogger() should be caught more explicitly

BIND 10 Development do-not-reply at isc.org
Fri Jun 17 13:39:56 UTC 2011


#1008: missing initLogger() should be caught more explicitly
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  vorner
  jinmei                             |                Status:  reviewing
                       Type:         |             Milestone:
  defect                             |  Sprint-20110628
                   Priority:  major  |            Resolution:
                  Component:         |             Sensitive:  0
  logging                            |           Sub-Project:  Core
                   Keywords:         |  Estimated Difficulty:  0.0
            Defect Severity:  N/A    |           Total Hours:  0
Feature Depending on Ticket:         |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by stephen):

 * owner:  stephen => vorner


Comment:

 > Well, my original proposal was not to store the messages but simply to
 drop them.
 True, but it set me thinking about going beyond that.  After all, if one
 of the logging functions has been called, it's not too complicated to
 store the information somewhere and output it when logging is up and
 running.

 > It might be worth noting which exception.
 Done.

 > This seems we are really panicking about the static initialization
 fiasco.
 Nicely put :-).  You are right, and I have got rid of the access function.

 > We have historical reasons already?
 Mainly because it was written before LoggerManager::init() (which actually
 does the initialization) and I didn't want to change all calls to
 initLogger().  On reflection though, leaving the logging initialization
 function as initLogger makes sense since there is then just one
 (overloaded) function to perform the initialization (as indicated in my
 post to bind10-dev),  I've removed the "historical" comment.

-- 
Ticket URL: <http://bind10.isc.org/ticket/1008#comment:9>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list