BIND 10 #1010: Configuration of the Python logging API

BIND 10 Development do-not-reply at isc.org
Mon Jun 20 15:10:54 UTC 2011


#1010: Configuration of the Python logging API
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  jelte
  stephen                            |                Status:  reviewing
                       Type:  task   |             Milestone:
                   Priority:  major  |  Sprint-20110628
                  Component:         |            Resolution:
  logging                            |             Sensitive:  0
                   Keywords:         |           Sub-Project:  DNS
            Defect Severity:  N/A    |  Estimated Difficulty:  0.0
Feature Depending on Ticket:         |           Total Hours:  0
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by vorner):

 * owner:  vorner => jelte


Comment:

 Hello

 The searching of path works for me now :-).

 Shouldn't the commented thing be removed? Or you want to test that this is
 rejected?

 {{{#!python
 -        isc.log.log_config_update({}, log_spec)
 +        #isc.log.log_config_update("{", log_spec)
 +        isc.log.log_config_update("{}", log_spec)
 }}}

 > I had thought about that, and I was not sure either. It would certainly
 save a bit of code, at the cost of two json conversions. Originally I
 chose this method because requiring JSON strings would make the interface
 slightly muddier. But now that I think about it, the JSON form is actually
 more flexible, and the actual conversion would be more or less hidden by
 the handler in the python code anyway.
 >
 > So yeah, let's do it through json. Currently simple json.dumps() calls
 suffice, so it's not that much of a change from the callers side.

 Well, I originally thought that the json.dumps() would be called from
 within the wrappers (it is possible to call python functions from C++
 somehow), so the user wouldn't need to. But as this is only in limited
 place, this is probably OK too.

 So, if the above one is to be deleted, I think it can be merged right
 away.

-- 
Ticket URL: <http://bind10.isc.org/ticket/1010#comment:7>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list