BIND 10 #1030: ImportError on OSX after merge of #1010

[BIND 10 Development]

#1030: ImportError on OSX after merge of #1010
-------------------------------------+-------------------------------------
                   Reporter:  jelte  |                 Owner:  jelte
                       Type:         |                Status:  closed
  defect                             |             Milestone:
                   Priority:  major  |  Sprint-20110628
                  Component:         |            Resolution:  fixed
  Unclassified                       |             Sensitive:  0
                   Keywords:         |           Sub-Project:  DNS
            Defect Severity:  N/A    |  Estimated Difficulty:  2.0
Feature Depending on Ticket:         |           Total Hours:  0
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by jelte):

 * status:  reviewing => closed
 * resolution:   => fixed


Comment:

 Replying to [comment:3 jinmei]:
 > It basically looks okay, but I have some minor comments and questions:
 >
 > '''log/__init__.py'''
 > - not actually for this branch, but don't we need these in
 log/__init__.py?
 > {{{
 > cwd = os.getcwd()
 > base = os.path.split(cwd)[0]
 > }}}

 oh, no they aren't necessary anymore, removed them.

 > - what's the purpose of changing sys.path to sys.path[:]?
 > {{{
 > -for base in sys.path:
 > +for base in sys.path[:]:
 > }}}
 >

 it's a shorthand for making a (shallow) copy instead of assigning the
 reference; in the loop we modify the list, which happened to work with
 append(), but wouldn't with insert()

 > '''changes to Makefile.am'''
 >
 > There is some inconsistency in using space and tab when adding
 $(LIBRARY_PATH_PLACEHOLDER).  For example, in bind10/tests/Makefile.am:
 > {{{
 >       echo Running test: $$pytest ; \
 > +        $(LIBRARY_PATH_PLACEHOLDER) \
 >       env
 PYTHONPATH=$(abs_top_srcdir)/src/lib/python:$(abs_top_builddir)/src/lib/python:$(abs_top_builddir)/src/bin/bind10
 \
 > }}}
 >
 > The added line is indented with space characters, while others were with
 a tab.
 >
 > Not a big deal, but as always I generally prefer a consistent style:-)

 yeah i agree, my bad (i blame the vi on macmini :p)

 merged and pushed, thanks for the quick look.

-- 
Ticket URL: <http://bind10.isc.org/ticket/1030#comment:5>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development