BIND 10 #769: ACLS: C++ access library
BIND 10 Development
do-not-reply at isc.org
Thu Jun 23 09:36:20 UTC 2011
#769: ACLS: C++ access library
-------------------------------------+-------------------------------------
Reporter: | Owner: vorner
stephen | Status: reviewing
Type: task | Milestone:
Priority: major | Sprint-20110628
Component: | Resolution:
Unclassified | Sensitive: 0
Keywords: | Sub-Project: DNS
Defect Severity: N/A | Estimated Difficulty: 0.0
Feature Depending on Ticket: ACL | Total Hours: 0
Add Hours to Ticket: 0 |
Internal?: 0 |
-------------------------------------+-------------------------------------
Changes (by jelte):
* owner: jelte => vorner
Comment:
Looks good, just have a couple of naming nits;
- tisg_key is misspelled, and perhaps should better be named tsig_key_name
if it's only the name (i agree that we should only pass around the name)
- I think the name Packet is both too general and too specific (heh); the
DNS packet is only one of the elements, and I still suspect it's going to
be one of the least important ones; I would prefer something like
RequestContext or ACLContext (or maybe just Context, since we're in acl
namespace already)
And perhaps the dns.[cc|h] files should be dnsacl, to reflect the libname
they'll end up in, but I can live with the current names, since we're
already in the acl directory.
--
Ticket URL: <http://bind10.isc.org/ticket/769#comment:8>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list