BIND 10 #738: Conversion of b10-auth to use new logging interface

[BIND 10 Development]

#738: Conversion of b10-auth to use new logging interface
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  vorner
  stephen                            |                Status:  reviewing
                       Type:         |             Milestone:
  enhancement                        |  Sprint-20110628
                   Priority:  major  |            Resolution:
                  Component:         |             Sensitive:  0
  b10-auth                           |           Sub-Project:  DNS
                   Keywords:         |  Estimated Difficulty:  6.0
            Defect Severity:  N/A    |           Total Hours:  0
Feature Depending on Ticket:         |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by stephen):

 * owner:  stephen => vorner


Comment:

 > First of, the distcheck fails with this...
 This turned out to be auth_log.h containing the line '#include
 "auth_messages.h"'.  auth_messages.h is created in the build directory,
 and so wasn't being found when the source and build directories were
 different.  Changing the file specification to '<auth/auth_messages.h>'
 fixed the problem.

 > Then, I'm thinking, the arg(exc.what()) is quite common. Would it help
 if we defined template specialization for exception?
 I think it would.  We talked about logging exceptions some time ago
 (should an exception be automatically logged when raised?) and it might be
 worth discussing the whole issue on bind10-dev.

 > And, finally, few minor points:...
 Typos and indentation fixed, some messages re-worded.

 > I think this should be LOG_ERROR, after all, failing command should be
 rare ...
 Agreed.  It was only LOG_DEBUG because in the original code, the message
 was only being issued if verbose_mode was set.

-- 
Ticket URL: <http://bind10.isc.org/ticket/738#comment:8>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development