BIND 10 #1001: busy loop in notify_out

[BIND 10 Development]

#1001: busy loop in notify_out
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  zzchen_pku
  jinmei                             |                Status:  reviewing
                       Type:         |             Milestone:
  defect                             |  Sprint-20110628
                   Priority:  major  |            Resolution:
                  Component:         |             Sensitive:  0
  xfrout                             |           Sub-Project:  DNS
                   Keywords:         |  Estimated Difficulty:  4.0
            Defect Severity:  High   |           Total Hours:  0
Feature Depending on Ticket:         |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by jelte):

 * owner:  jelte => zzchen_pku


Comment:

 tests:

 is it also possible to add a test that checks if nonblock_event is
 cleared?

 code:

 in general, I think this is a lot better than what we had. I do have some
 comments on the code and the documentation, but they are probably not
 really related to this specific ticket.

 First of all, it is noted by TODO that it shouldn't look for slaves
 directly in the database. Certainly true, and I think we might not want
 the code in notify to look for it at all (but rather have it passed by
 xfrout, which also has a better chance to discover which slaves it should
 not send to. I'm mainly thinking of the problem i have right now that my
 bind10 is sending notifies to itself)

 ZoneNotifyInfo, the docstring of __init__ talks about one specific member
 variable. That info should be placed at that variable.

 The comment about exponential backoff on line 381 should go one line
 earlier imo

-- 
Ticket URL: <http://bind10.isc.org/ticket/1001#comment:6>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development