BIND 10 #979: Logic operator ACLs

[BIND 10 Development]

#979: Logic operator ACLs
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  vorner
  vorner                             |                Status:  reviewing
                       Type:  task   |             Milestone:
                   Priority:  major  |  Sprint-20110628
                  Component:         |            Resolution:
  Unclassified                       |             Sensitive:  0
                   Keywords:         |           Sub-Project:  DNS
            Defect Severity:  N/A    |  Estimated Difficulty:  4.0
Feature Depending on Ticket:  ACL    |           Total Hours:  0
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by stephen):

 * owner:  stephen => vorner


Comment:

 '''logic_check.h'''

 getSubexpressions(): &!**i is correct, although shared_ptr does provide
 the "get()" method to return the pointer to the element.  So "i->get()"
 could also be considered (and may be preferred as being less cryptic).

 '''logic_check_test.cc'''
 Are we allowing nested expressions, e.g.
 {{{
 {ALL: [
     {ANY: [
         {"src-ip": "1.2.3.4"},
         {"src-ip": "5.6.7.8"}
     ]},
     {"dest-ip": "9.10.11.12"}
 ]}
 }}}
 If so, there should be a unit test for them.

 What logic result do we expect an empty expression to come back with?
 There should be a test for it.

 With the sub-expression tests, I think tests should be added to check that
 both logic operators can return both true and false:
  * !AnyOf returns false if all elements are false
  * !AllOf returns true if the all elements are true.

-- 
Ticket URL: <http://bind10.isc.org/ticket/979#comment:7>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development