BIND 10 #979: Logic operator ACLs

[BIND 10 Development]

#979: Logic operator ACLs
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  stephen
  vorner                             |                Status:  reviewing
                       Type:  task   |             Milestone:
                   Priority:  major  |  Sprint-20110628
                  Component:         |            Resolution:
  Unclassified                       |             Sensitive:  0
                   Keywords:         |           Sub-Project:  DNS
            Defect Severity:  N/A    |  Estimated Difficulty:  4.0
Feature Depending on Ticket:  ACL    |           Total Hours:  0
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by vorner):

 * owner:  vorner => stephen


Comment:

 Hello

 Replying to [comment:7 stephen]:
 > '''logic_check.h'''
 >
 > getSubexpressions(): &!**i is correct, although shared_ptr does provide
 the "get()" method to return the pointer to the element.  So "i->get()"
 could also be considered (and may be preferred as being less cryptic).

 Right, I might have different bar about cryptic code (after teaching perl
 (therefore learning it (and I want to learn lisp one day too))).

 > '''logic_check_test.cc'''
 > Are we allowing nested expressions, e.g.
 > [...]
 > If so, there should be a unit test for them.

 It somehow directly follows from having any expression as subexpression,
 but I added the test.

 > What logic result do we expect an empty expression to come back with?
 There should be a test for it.

 If I understand what you mean, the test is already there,
 `LogicCreatorTest::empty`.

 > With the sub-expression tests, I think tests should be added to check
 that both logic operators can return both true and false:
 >  * !AnyOf returns false if all elements are false
 >  * !AllOf returns true if the all elements are true.

 ACK.

-- 
Ticket URL: <http://bind10.isc.org/ticket/979#comment:9>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development