BIND 10 #1039: Modify resolver messages

[BIND 10 Development]

#1039: Modify resolver messages
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  vorner
  stephen                            |                Status:  reviewing
                       Type:         |             Milestone:
  enhancement                        |  Sprint-20110628
                   Priority:  minor  |            Resolution:
                  Component:         |             Sensitive:  0
  logging                            |           Sub-Project:  DNS
                   Keywords:         |  Estimated Difficulty:  0.5
            Defect Severity:  N/A    |           Total Hours:  0
Feature Depending on Ticket:         |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by stephen):

 * owner:  stephen => vorner
 * estimatedhours:  0.0 => 0.5
 * component:  Unclassified => logging


Comment:

 > RESOLVER_PROTOCOL_ERROR is used twice.
 Well-spotted.  Changed the second occurrence to RESOLVER_MESSAGE_ERROR.

 > RESOLVER_RECQ_SETUP is still abbreviated, what does the REC mean?
 RECQ was an abbreviation for !RecursiveQuery: I've changed it to QUERY.
 (There is a naming issue in the resolver library where there are messages
 for !RecursiveQuery and !RunningQuery objects.  However, as only one is
 mentioned here, QUERY is suitably non-ambiguous.)

 > RESOLVER_NOT_ONE_QUEST still abbreviated, quest being a valid word, it
 looks strange.
 and
 > It took me a while to find out TMO is not a typo of TWO, but TIMEOUT.
 Maybe use just TIME instead
 All these messages are a trade-off between readability and the length of
 the identifier: at what point do we decide it is too long? However, as I
 added the identifiers UNEXPECTED_RESPONSE and UNSUPPORTED_OPCODE, I've
 used these as a benchmark for maximum length and was able to expand more
 or less all abbreviations.

 One option would be to try to reduce the length of the prefix - would it
 be worth coming up with a three- or four-letter abbreviation for all of
 the different modules (e.g. abbreviating RESOLVER_ to RES_)?

-- 
Ticket URL: <http://bind10.isc.org/ticket/1039#comment:5>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development