BIND 10 #1001: busy loop in notify_out

[BIND 10 Development]

#1001: busy loop in notify_out
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  zzchen_pku
  jinmei                             |                Status:  reviewing
                       Type:         |             Milestone:
  defect                             |  Sprint-20110628
                   Priority:  major  |            Resolution:
                  Component:         |             Sensitive:  0
  xfrout                             |           Sub-Project:  DNS
                   Keywords:         |  Estimated Difficulty:  4.0
            Defect Severity:  High   |           Total Hours:  0
Feature Depending on Ticket:         |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by jelte):

 * owner:  jelte => zzchen_pku


Comment:

 Replying to [comment:7 zzchen_pku]:
 > Replying to [comment:6 jelte]:
 > > tests:
 > >
 > > is it also possible to add a test that checks if nonblock_event is
 cleared?
 > Done.

 hmm, the assert seems a bit superfluous (since that code wouldn't be
 reached as long as isSet() is true, unless there may be something else
 setting it immediately again. But as we can't really tell how soon it'll
 get to clearing it, I don't really know how we can do that better, so I'm
 ok with this.

 > > First of all, it is noted by TODO that it shouldn't look for slaves
 directly in the database. Certainly true, and I think we might not want
 the code in notify to look for it at all (but rather have it passed by
 xfrout, which also has a better chance to discover which slaves it should
 not send to. I'm mainly thinking of the problem i have right now that my
 bind10 is sending notifies to itself)
 > Yeah, shall we create a ticket for it now?

 please do :)

 > > ZoneNotifyInfo, the docstring of __init__ talks about one specific
 member variable. That info should be placed at that variable.
 > >
 > > The comment about exponential backoff on line 381 should go one line
 earlier imo
 > Updated.
 > Please check, thanks.

 looks good

 I think this code can be merged

-- 
Ticket URL: <http://bind10.isc.org/ticket/1001#comment:8>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development