BIND 10 #999: Integrate ACLs into b10-resolver

[BIND 10 Development]

#999: Integrate ACLs into b10-resolver
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  jinmei
  vorner                             |                Status:  reviewing
                       Type:  task   |             Milestone:
                   Priority:  major  |  Sprint-20110628
                  Component:         |            Resolution:
  Unclassified                       |             Sensitive:  0
                   Keywords:         |           Sub-Project:  DNS
            Defect Severity:  N/A    |  Estimated Difficulty:  4.0
Feature Depending on Ticket:         |           Total Hours:  0
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------

Comment (by jinmei):

 Replying to [comment:17 vorner]:

 > > >  * Should we test localhost addresses as well? (and in the following
 test) They are default, so to check that they are default at the right
 place.
 > >
 > > I don't understand these comments...in the first sentence are you
 > > suggesting we should explicitly test 127.0.0.1 and ::1 instead of
 > > 192.0.2.1, etc?  We could do so, but in this context I don't see
 > > an essential difference between these cases.
 >
 > Well, I think we should do it to test that the default (allowing
 localhost) comes from the spec file, not the code itself. Because, if the
 code loaded the currently-spec-file default without the spec file, the
 localhost would distinguish it, while the current 192.0.2.1 test wouldn't.

 Ah, okay.  I believe I addressed it in ab31e2f.

 > > >  * You enable debug logging in tests. But should we spam the outputs
 with the debug logging?
 [...]
 > And isn't it better to enable it using the environment variables,
 globally? The problem I see with this is, I have stderr red-colored while
 running tests. And with the logging I see a lot of red, which makes it
 harder to spot real failures and complaints. Maybe I'll just turn the
 logging off using the variables. Anyway, I see it inconsistent with the
 rest of the tests. Maybe we want to discuss it and put the DEBUG level as
 the default?

 Making it switchable is a good idea (but I think the default log level
 should be quite verbose).  I also admit this is not the main subject
 of this ticket.  So I've reverted this part of change (041c3ec).  I'll
 update the general ticket (I found it; it's #1024) about the run time
 switch.

 Is there anything else I overlooked for this ticket?

-- 
Ticket URL: <http://bind10.isc.org/ticket/999#comment:18>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development