BIND 10 #759: Conversion of cfgmgr to use the new logging interface
BIND 10 Development
do-not-reply at isc.org
Tue Jun 28 09:38:20 UTC 2011
#759: Conversion of cfgmgr to use the new logging interface
-------------------------------------+-------------------------------------
Reporter: | Owner: vorner
stephen | Status: reviewing
Type: | Milestone:
enhancement | Sprint-20110628
Priority: major | Resolution:
Component: | Sensitive: 0
logging | Sub-Project: DNS
Keywords: | Estimated Difficulty: 2.0
Defect Severity: N/A | Total Hours: 0
Feature Depending on Ticket: |
Add Hours to Ticket: 0 |
Internal?: 0 |
-------------------------------------+-------------------------------------
Changes (by jelte):
* owner: jelte => vorner
Comment:
Replying to [comment:6 vorner]:
> Hello
>
> I tried to write the logging API so it shouldn't be needed to call str
on every parameter. You tried it and it didn't work (therefore it's bug in
the API) or you just put them there automatically?
>
Oh, no that's just an effect from trying to do the call conversion as
automatic as possible, removed them
> Why is cfgmgr_messages.py both in python_PYTHON and python_SCRIPTS? Is
it really needed to be executable? Isn't some kind of EXTRA_DIST on the
message file needed?
>
> Hmm, and it fails in check, „Didn't find a call to
isc.util.process.rename in
src/src/lib/python/isc/config/cfgmgr_messages.py“, which is probably
related to the SCRIPTS thing.
It was to get it both regenerated automatically and installed in the right
place. But I've removed the _SCRIPTS and added the generation target to
all-local, and the source file to EXTRA_DIST, so it should work now
> I believe `CFGMGR_DATA_READ_ERROR` should be fatal, not error, as the
manager can't continue after that.
ok (CFGMGR_CC_SESSION_ERROR too then, btw)
--
Ticket URL: <http://bind10.isc.org/ticket/759#comment:8>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list