BIND 10 #614: Run unit tests with Valgrind

[BIND 10 Development]

#614: Run unit tests with Valgrind
-------------------------------------+-------------------------------------
                 Reporter:  stephen  |                Owner:  jinmei
                     Type:  task     |               Status:  accepted
                 Priority:  major    |            Milestone:  A-Team-
                Component:           |  Sprint-20110309
  Unclassified                       |           Resolution:
                 Keywords:           |            Sensitive:  0
Estimated Number of Hours:  0.0      |  Add Hours to Ticket:  0
                Billable?:  1        |          Total Hours:  0
                Internal?:  0        |
-------------------------------------+-------------------------------------

Comment (by jinmei):

 Replying to [comment:3 vorner]:
 > Hello
 >
 > I have two scripts in the branch:

 The scripts basically seem okay in the context of this ticket.  Some
 minor comments:

 - when merge, maybe tools/README will have to be updated (it's not
   necessarily for "helping developers maintain the source tree")
 - just FYI: valgrind on bind10.isc.org doesn't recognize the
   --read-var-info option, so we'll have to specify FLAGS
 - this message wasn't really clear to me and I had to read the comment
   inside the script to know I had to run it on the top directory:
 {{{
 Did you run configure? Do you call me from the top bind10 directory?
 }}}
   I'm not really sure how we can improve it, but perhaps something
   like this is better: "Maybe you are running this script under the
   "tools" directory; make sure you run it at the top bind10 directory"

 - s/witouth/without/?
 {{{
     echo "No test was found. It is possible you configured witouth --with-
 gtest or you run it from wrong directory" >&2
 }}}

 As for using bash, I think it's okay because this is an optional
 feature and because valgrind is (realistically) quite linux
 centric anyway...(hmm I didn't know it's available for MacOS X, too.
 But in either case bash should be generally available).

 As for using perl, again, I have no problem with it at least at the
 moment, also with the understanding that perl is pretty ubiquitously
 available.  But I'd like to avoid creating a precedent of a chaos
 where everyone is introducing tool scripts using their favorite
 language saying "I like ruby/java/haskel/xxx and it just seemed to me
 using XXX was the best way to do this job".  So, I'd suggest adding
 a note about the choice of perl, and, unless it's your intent, it's
 not for opening the possibility of the chaos (or, better than that,
 we'll eventually rewrite it in our primary script language, python, if
 it's a plan).

 > I'd like to merge these patches in master and keep them there for future
 generations. I think this doesn't need a changelog, since it's our tool.
 >
 > '''The results'''

 I've not fully examined the results yet (I thought it's beyond the
 original scope of this ticket), but anyway,

 > May I create tickets for each of these tasks (except the
 AddressSelection)? I would the output as attachment for each of them.

 I think it's a good idea.

-- 
Ticket URL: <https://bind10.isc.org/ticket/614#comment:5>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development