BIND 10 #606: See which of BIND 9 tests can be re-used or re-implemented for BIND 10

[BIND 10 Development]

#606: See which of BIND 9 tests can be re-used or re-implemented for BIND 10
-------------------------------------+-------------------------------------
                 Reporter:  stephen  |                Owner:  jinmei
                     Type:  task     |               Status:  reviewing
                 Priority:  major    |            Milestone:  A-Team-
                Component:           |  Sprint-20110309
  b10-auth                           |           Resolution:
                 Keywords:           |            Sensitive:  0
Estimated Number of Hours:  3.0      |  Add Hours to Ticket:  0
                Billable?:  1        |          Total Hours:  0
                Internal?:  0        |
-------------------------------------+-------------------------------------
Changes (by vorner):

 * owner:  vorner => jinmei


Comment:

 Hello

 I have few comments.
  - Why is the unlink in boss's dump pid needed? Wouldn't overwriting the
 file (eg. open(filename, 'w')) be enough?
  - The README contains note of make test, but the toplevel makefile has
 systest, not test.
  - When I run make distcheck, it fails for me:
 {{{
 make[3]: Entering directory
 `/home/vorner/work/bind10/bind10-devel-20110224/_build/tests/system'
 rm -rf .libs _libs
 rm -f *.lo
 test -z "conf.sh" || rm -f conf.sh
 sh cleanall.sh
 test . = "../../../tests/system" || test -z "" || rm -f
 sh: cleanall.sh: No such file or directory
 make[3]: *** [distclean-local] Error 127
 make[3]: *** Waiting for unfinished jobs....
 make[3]: Leaving directory
 `/home/vorner/work/bind10/bind10-devel-20110224/_build/tests/system'
 make[2]: *** [distclean-recursive] Error 1
 make[2]: Leaving directory
 `/home/vorner/work/bind10/bind10-devel-20110224/_build/tests'
 make[1]: *** [distclean-recursive] Error 1
 make[1]: Leaving directory
 `/home/vorner/work/bind10/bind10-devel-20110224/_build'
 make: *** [distcheck] Error 1
 }}}
  - The digcomp.pl seems like a bad perl code (not wrong, just not
 following usual conventions, like declaring variables with my, has a lot
 of duplicate code, using "none" instead of undef). I get this one is
 imported and the goal is not to cleanup all imported code, but I believe
 it would be worth a note to either port it to python sometime or clean
 this one up.
  - The last line of the test is kind of confusing. It starts with E: which
 probably means End, but I thought it was error for a while. I had to
 examine the exit code to see it terminated successfully.

-- 
Ticket URL: <http://bind10.isc.org/ticket/606#comment:7>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development