BIND 10 #499: TCP (as a client)

[BIND 10 Development]

#499: TCP (as a client)
-------------------------------------+-------------------------------------
                 Reporter:  shane    |                Owner:  stephen
                     Type:           |               Status:  reviewing
  enhancement                        |            Milestone:  R-Team-
                 Priority:  minor    |  Sprint-20110308
                Component:           |           Resolution:
  resolver                           |            Sensitive:  0
                 Keywords:           |  Add Hours to Ticket:  0
Estimated Number of Hours:  5.0      |          Total Hours:  0
                Billable?:  1        |
                Internal?:  0        |
-------------------------------------+-------------------------------------
Changes (by jelte):

 * owner:  jelte => stephen


Comment:

 I've fixed a few typos in some comments, see commit
 0b42ead35810e82a97561d71309283950ca9d5a3

 The code looks good and can be merged imo.

 I did notice that it doesn't work with bigtxt.tjeb.nl when in forwarder
 mode. This isn't a problem in the TCP code itself but apparently not all
 flags are copied in forwarder mode (at least, I think the forwarder should
 send back the truncated packet rather than retrying with tcp), I can
 create a ticket for that, but I think it may need to be a bit more
 general, perhaps we can discuss that tomorrow.

 Another comment I had, there's a TODO in tcp_socket.h (line 175), about
 the two octets of tcp data length. I agree this can be done better, but
 disagree with the suggestion there (to put it in buffer). While asio
 should really be about sending and receiving data, the buffer should imo
 be just about storing it, and have no knowledge of protocols :)

-- 
Ticket URL: <http://bind10.isc.org/ticket/499#comment:5>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development